Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylebook path to exceptions for classic themes in site editor. #7865

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Nov 22, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/62509

Syncs changes from WordPress/gutenberg#66851 and WordPress/gutenberg#68174 to core.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc
Copy link
Contributor

This has got conflicts following the change to path based site editor URLs.

As the query string parameter wasn't used and the wp_die() call removed, I am not sure this is needed anymore. But I am also not not sure.

@tellthemachines
Copy link
Contributor Author

As the query string parameter wasn't used and the wp_die() call removed, I am not sure this is needed anymore. But I am also not not sure.

This PR was never updated with the latest changes from the two Gutenberg PRs linked above. The intention is to replace the current "Patterns" submenu item under "Appearance" in classic themes with a "Design" item that leads to the site editor, where there are links to both Patterns and Style book.

Unfortunately I'm not able to update the PR with those changes at this point so would really appreciate if anyone could take this over!

The submenu item is added via a filter in Gutenberg, but I think in core we should be able to add it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants