Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Gutenberg plugin activation test on older WP versions #6396

Closed
wants to merge 8 commits into from
+14 −1
Closed

Skip Gutenberg plugin activation test on older WP versions #6396

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3c0c02
Skip Gutenberg plugin activation on older WP versions
ockham Apr 16, 2024
e11ab87
Rename to wpVersion
ockham Apr 16, 2024
69d3e06
Revert "Rename to wpVersion"
ockham Apr 16, 2024
dea3100
Revert "Skip Gutenberg plugin activation on older WP versions"
ockham Apr 16, 2024
f6d82c3
Alternative approach: Check for REST API error
ockham Apr 16, 2024
a5306db
Revert "Alternative approach: Check for REST API error"
ockham Apr 16, 2024
a604234
Alternative approach: Skip test upon activation error
ockham Apr 16, 2024
a83cefc
Re-throw any other kind of error
ockham Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/e2e/specs/gutenberg-plugin.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,20 @@ test.describe( 'Gutenberg plugin', () => {

expect( plugin.status ).toBe( 'inactive' );

await requestUtils.activatePlugin( 'gutenberg' );
try {
await requestUtils.activatePlugin( 'gutenberg' );
} catch ( error ) {
if (
typeof error === 'object' &&
error !== null &&
Object.prototype.hasOwnProperty.call( error, 'code' ) &&
error.code === 'plugin_wp_incompatible'
) {
test.skip();
} else {
throw error;
}
}

plugin = await requestUtils.rest( {
path: 'wp/v2/plugins/gutenberg/gutenberg',
Expand Down
Loading