Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Add support for the rest of the common IN BODY tags. #5864

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Jan 13, 2024

TODO

  • Run the html5lib tests against these updated elements
  • Generate unit tests to cover these updated elements
  • Handle closing tags for the special elements? These might be covered already by the "any other end tag" section.

Description

Adds support for the rest of the "easy" and common tags to support within the IN BODY insertion mode. The goal of this patch is to unlock as many posts for full support as possible without requiring that we add too much additional complexity into the HTML Processor. In other words: what can we support in 6.5 without putting too much pressure on review and testing?

Adds support for the following elements:

  • APPLET
  • IFRAME
  • MARQUEE
  • NOEMBED
  • OBJECT
  • TEXTAREA
  • WBR
  • XMP

@dmsnell dmsnell force-pushed the html-api/add-support-for-most-of-the-rest-of-the-common-tags branch 2 times, most recently from 8c93155 to 89a226f Compare January 19, 2024 23:38
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell dmsnell force-pushed the html-api/add-support-for-most-of-the-rest-of-the-common-tags branch from 89a226f to 7939dcb Compare January 20, 2024 00:18
@sirreal
Copy link
Member

sirreal commented Sep 3, 2024

I think this has been superseded, can we close the PR?

@dmsnell
Copy link
Member Author

dmsnell commented Sep 3, 2024

Yes, thank you @sirreal

@dmsnell dmsnell closed this Sep 3, 2024
@dmsnell dmsnell deleted the html-api/add-support-for-most-of-the-rest-of-the-common-tags branch September 3, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants