Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPUnit tests for wp_parse_slug_list function #5850

Closed
wants to merge 3 commits into from

Conversation

pbearne
Copy link

@pbearne pbearne commented Jan 9, 2024

A new phpunit test file is added specifically for testing the 'wp_parse_slug_list' function. Different scenarios are covered including handling of plain numbers, strings with spaces, strings with commas, and HTML. This ensures that the function responds correctly to a wide array of inputs, improving overall software reliability and stability.

Trac ticket: https://core.trac.wordpress.org/ticket/60217

A new phpunit test file is added specifically for testing the 'wp_parse_slug_list' function. Different scenarios are covered including handling of plain numbers, strings with spaces, strings with commas, and HTML. This ensures that the function responds correctly to a wide array of inputs, improving overall software reliability and stability.
Copy link

github-actions bot commented Jan 9, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Updated the variable name 'list' to 'input_list' to get a more descriptive and precise meaning in wpParseSlugList.php. Also, a new test 'dup_id' is added to cover a scenario with duplicate identifiers in the input list. This will improve the comprehensiveness of the tests.
Added a comment block to annotate the 'data_wp_parse_slug_list' function, providing information on its associated ticket 60217. This enhances the readability and traceability of the code within the 'wpParseSlugList.php' test file.
@swissspidy
Copy link
Member

@swissspidy swissspidy closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants