Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate old persistence system configuration - fixes block editor usage data #3423

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Oct 10, 2022

In #3253 I was a little too eager to remove the old preferences persistence configuration. This system is still used in the block editor for block inserter usage, so removing this accidentally caused the 'most used blocks' feature to stop working.

Trac ticket: https://core.trac.wordpress.org/ticket/56778


Steps to reproduce:
Prerequisite: Remove the WORDPRESS_DATA_USER_{n} local storage data (where {n} is your used id).

  1. Open up a block editor and insert the same block a few times (e.g. Code block).
  2. Trigger the / inserter an notice Code is now top of the list.
  3. Reload the block editor.
  4. Trigger the / inserter again and noticed Code block is no longer top of the list.

In trunk: The code block is no longer present at the top of the list.
In this branch: The code block should be persisted across sessions as the most used block.

@audrasjb
Copy link
Contributor

@audrasjb audrasjb closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants