Skip to content

Commit

Permalink
Editor: fix classname output on blocks without layout.
Browse files Browse the repository at this point in the history
Prevents layout classnames from being output on blocks with no layout support and no child layout classnames by returning early from `wp_render_layout_support_flag`.

Props andrewserong.
Fixes #60292.


git-svn-id: https://develop.svn.wordpress.org/trunk@57328 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
tellthemachines committed Jan 23, 2024
1 parent 3c4fbc3 commit c9f04d4
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/wp-includes/block-supports/layout.php
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,9 @@ function wp_render_layout_support_flag( $block_content, $block ) {
$processor->add_class( $class_name );
}
return $processor->get_updated_html();
} elseif ( ! $block_supports_layout ) {
// Ensure layout classnames are not injected if there is no layout support.
return $block_content;
}

$global_settings = wp_get_global_settings();
Expand Down
20 changes: 20 additions & 0 deletions tests/phpunit/tests/block-supports/layout.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ public function test_outer_container_not_restored_for_aligned_image_block_with_t
/**
* @ticket 57584
* @ticket 58548
* @ticket 60292
*
* @dataProvider data_layout_support_flag_renders_classnames_on_wrapper
*
Expand Down Expand Up @@ -250,6 +251,25 @@ public function data_layout_support_flag_renders_classnames_on_wrapper() {
),
'expected_output' => '<div class="wp-block-group"><div class="wp-block-group__inner-wrapper is-layout-flow wp-block-group-is-layout-flow"></div></div>',
),
'skip classname output if block does not support layout and there are no child layout classes to be output' => array(
'args' => array(
'block_content' => '<p>A paragraph</p>',
'block' => array(
'blockName' => 'core/paragraph',
'attrs' => array(
'style' => array(
'layout' => array(
'selfStretch' => 'fit',
),
),
),
'innerBlocks' => array(),
'innerHTML' => '<p>A paragraph</p>',
'innerContent' => array( '<p>A paragraph</p>' ),
),
),
'expected_output' => '<p>A paragraph</p>',
),
);
}

Expand Down

0 comments on commit c9f04d4

Please sign in to comment.