This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Style Variations #92
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/wp/6.2/theme.json", | ||
| "version": 2, | ||
| "title": "Dark Sans-serif", | ||
| "settings": { | ||
| "color": { | ||
| "palette": [ | ||
| { | ||
| "color": "#222222", | ||
| "name": "Base", | ||
| "slug": "base" | ||
| }, | ||
| { | ||
| "color": "#ffffff", | ||
| "name": "Contrast", | ||
| "slug": "contrast" | ||
| }, | ||
| { | ||
| "color": "#222222", | ||
| "name": "Primary", | ||
| "slug": "primary" | ||
| }, | ||
| { | ||
| "color": "#a2a2a2", | ||
| "name": "Secondary", | ||
| "slug": "secondary" | ||
| }, | ||
| { | ||
| "color": "#303030", | ||
| "name": "Tertiary", | ||
| "slug": "tertiary" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "styles": { | ||
| "typography": { | ||
| "fontFamily": "var:preset|font-family|inter" | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/wp/6.2/theme.json", | ||
|
There was a problem hiding this comment. This can probably be the 6.3 schema There was a problem hiding this comment. I checked twentytwentythree using their trunk schema and also twentytwentyfour theme.json use trunk. Can I Updating schema from version 6.2 to trunk |
||
| "version": 2, | ||
| "title": "Dark serif", | ||
| "settings": { | ||
| "color": { | ||
| "palette": [ | ||
| { | ||
| "color": "#222222", | ||
| "name": "Base", | ||
| "slug": "base" | ||
| }, | ||
| { | ||
| "color": "#ffffff", | ||
| "name": "Contrast", | ||
| "slug": "contrast" | ||
| }, | ||
| { | ||
| "color": "#222222", | ||
|
There was a problem hiding this comment. I don't think we should be duplicating colors here, it's confusing for the user. Will we break patterns or templates if we remove it? There was a problem hiding this comment. Will not break but will get contrast color from default style There was a problem hiding this comment. Yea, we should not be duplicated color values. It's not helpful having two controls in the color palette UI for selecting the same color. |
||
| "name": "Primary", | ||
| "slug": "primary" | ||
| }, | ||
| { | ||
| "color": "#a2a2a2", | ||
| "name": "Secondary", | ||
| "slug": "secondary" | ||
| }, | ||
| { | ||
| "color": "#303030", | ||
| "name": "Tertiary", | ||
| "slug": "tertiary" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/wp/6.2/theme.json", | ||
| "version": 2, | ||
| "title": "Light Sans-serif", | ||
| "settings": { | ||
| "color": { | ||
| "palette": [ | ||
| { | ||
| "color": "#f9f9f9", | ||
| "name": "Base", | ||
| "slug": "base" | ||
| }, | ||
| { | ||
| "color": "#000000", | ||
| "name": "Contrast", | ||
| "slug": "contrast" | ||
| }, | ||
| { | ||
| "color": "#000000", | ||
| "name": "Primary", | ||
| "slug": "primary" | ||
| }, | ||
| { | ||
| "color": "#636363", | ||
| "name": "Secondary", | ||
| "slug": "secondary" | ||
| }, | ||
| { | ||
| "color": "#ffffff", | ||
| "name": "Tertiary", | ||
| "slug": "tertiary" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we expand on this to include the different font weights @matiasbenedetto @mikachan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I don't think so because this part of the theme.json only sets the default preset for the elements. The Inter fonts weights were already created in
settings.typography.fontFamilies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inter has been removed from the theme; please see #72 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. and also need to color palette update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggestion @carolinan