This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
Try to match Twilight and typography preset 4 #461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial for #423
There were many differences between the typography preset and the combined variation.
I updated some values to match Figma.
I removed the hover styles from the buttons, so that it falls back to the color-mix in theme.json.
The exception is the one button in section 2 that has a different background and text color.
Finally, I increased the padding on the buttons to match Figma, but used rem instead of px.
Testing Instructions
Compare the typography settings and styles in the combined variation and the typography preset, they should match.
Compare the color settings and styles in the combined variation and the color preset, they should match.
Look for any settings or styles that are duplicates, that are the same as in theme.json.