Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try to match Twilight and typography preset 4 #461

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 29, 2024

Description
Partial for #423

There were many differences between the typography preset and the combined variation.
I updated some values to match Figma.
I removed the hover styles from the buttons, so that it falls back to the color-mix in theme.json.
The exception is the one button in section 2 that has a different background and text color.
Finally, I increased the padding on the buttons to match Figma, but used rem instead of px.

Testing Instructions
Compare the typography settings and styles in the combined variation and the typography preset, they should match.
Compare the color settings and styles in the combined variation and the color preset, they should match.
Look for any settings or styles that are duplicates, that are the same as in theme.json.

Copy link

github-actions bot commented Sep 29, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan
Copy link
Contributor Author

Just like in some other variations, I don't think the "written by" in the default single post template looks good: It is inconsistent in size, font family and capitalization:
image

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 29, 2024
@carolinan carolinan marked this pull request as ready for review September 29, 2024 02:57
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan merged commit 4cde379 into trunk Sep 30, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant