Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try to match Afternoon and typography preset 3 #459

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 28, 2024

Description
Partial for #423

Typography

I copied the font size settings from Afternoon to preset 3.
I copied the block typography styles from Afternoon to preset 3.
I copied the element typography styles from Afternoon to preset 3.

Testing Instructions
Compare the typography settings and styles in the two files, they should match.
Look for any typography settings or styles that are duplicates, that are the same as in theme.json.

Color

Accent 1 and Accent 2 did not match Figma; accent 1 was assigned to accent 2 and vice versa. I updated this.
One section style that was in Figma was not in the theme, so I replaced a section style that was duplicate.

Copy link

github-actions bot commented Sep 28, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 28, 2024
@carolinan carolinan changed the title Try to match Afternoon and preset 3 Try to match Afternoon and typography preset 3 Sep 28, 2024
@carolinan
Copy link
Contributor Author

In my opinion, it does not look good that the paragraph "Written by" is small and the author is medium:
image

@carolinan carolinan marked this pull request as ready for review September 29, 2024 00:53
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan merged commit d7e11d1 into trunk Sep 30, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant