Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try to match Dusk and typography preset-2 #458

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 28, 2024

Description
Partial for #423

Typography

Testing Instructions
Compare the typography settings and styles in the two files, they should match.
Look for any typography settings or styles that are duplicates, that are the same as in theme.json.

Color

I copied the entire styles section from the combined 03-Dusk to the color preset 03-Dusk, and from there, removed anything that was not color related.

Buttons

I updated the buttons in the section styles to match Figma.
I updated the hover colors using the color-mix.

Copy link

github-actions bot commented Sep 28, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 28, 2024
@carolinan carolinan marked this pull request as ready for review September 29, 2024 01:21
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor Author

carolinan commented Sep 29, 2024

Section styles before:
image

After:
image

@carolinan
Copy link
Contributor Author

The link color on the site title is being overwritten:

image

@carolinan carolinan merged commit 92ace59 into trunk Sep 30, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant