Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try to match noon and typography preset-1 #457

Merged
merged 16 commits into from
Sep 30, 2024
Merged

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 28, 2024

Description
Partial for #423

Typography

I copied the font size setting from Noon to preset 1.
I copied the body font size style from Noon to preset 1.
I copied the block typography styles from Noon to preset 1
I copied the element typography styles from Noon to preset 1

I changed the format in Noon to use "pipes":

- "fontSize": "var(--wp--preset--font-size--medium)",
+ "fontSize": "var:preset|font-size|medium",

Testing Instructions
Compare the typography settings and styles in the two files, they should match.
Look for any typography settings or styles that are duplicates, that are the same as in theme.json.

Color

I copied the entire styles section from the combined 02-Noon to the color preset 02-Noon, and from there, removed anything that was not color related.

Buttons

I removed the hover styles and added the color-mix to two sections.

Copy link

github-actions bot commented Sep 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Sep 28, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan
Copy link
Contributor Author

carolinan commented Sep 28, 2024

I can see why the heading sizes needs to be one size larger than the defaults from theme.json.
I don't have a strong opinion, but the jump in size from h1 to h2 is rather large?

H1 is 58px, (clamp(2.625rem, 2.625rem +((1vw - 0.2rem)* 1.569), 3.625rem);)
H2 is 32 (clamp(1.75rem, 1.75rem +((1vw - 0.2rem)* 0.392), 2rem);)
image

Compared with the sizes in Figma:
H1 is 42px
H2 is 28.8px
image

@carolinan carolinan changed the title WIP: try to match noon and typography preset-1 Try to match noon and typography preset-1 Sep 28, 2024
@carolinan
Copy link
Contributor Author

carolinan commented Sep 28, 2024

This does not look good in my opinion. This is from the default single post template:
image

"Written by" is a paragraph and uses Literata, inherited from the body.
The post term uses Beiruti, because in the original Figma design, Beiruti is used for the post tags that are below the post
content.

In Figma, the whole line uses Beiruti, font size 20px; https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=77-584&t=U5e7KtwXbVErNU0v-4

@carolinan
Copy link
Contributor Author

carolinan commented Sep 28, 2024

On the default home template, the post title is set to X-large in the markup.
Is it too small?

image

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 28, 2024
@carolinan
Copy link
Contributor Author

carolinan commented Sep 30, 2024

There are two ways to sort the section styles from light to dark:

  • Update the order of the colors in the palette
  • Override the colors in each section style, under styles > variations

Do we want to do either of these?

@jasmussen
Copy link
Contributor

This works well for me:

changes

@carolinan carolinan merged commit 177d0f6 into trunk Sep 30, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants