-
Notifications
You must be signed in to change notification settings - Fork 127
Try to match noon and typography preset-1 #457
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
The post author and post author name blocks have the same styles as the body, except for the font family.
This does not look good in my opinion. This is from the default single post template: "Written by" is a paragraph and uses Literata, inherited from the body. In Figma, the whole line uses Beiruti, font size 20px; https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=77-584&t=U5e7KtwXbVErNU0v-4 |
There are two ways to sort the section styles from light to dark:
Do we want to do either of these? |
Description
Partial for #423
Typography
I copied the font size setting from Noon to preset 1.
I copied the body font size style from Noon to preset 1.
I copied the block typography styles from Noon to preset 1
I copied the element typography styles from Noon to preset 1
I changed the format in Noon to use "pipes":
Testing Instructions
Compare the typography settings and styles in the two files, they should match.
Look for any typography settings or styles that are duplicates, that are the same as in theme.json.
Color
I copied the entire styles section from the combined 02-Noon to the color preset 02-Noon, and from there, removed anything that was not color related.
Buttons
I removed the hover styles and added the color-mix to two sections.