Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Move the CSS for the outline button :hover style to theme.json #447

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 28, 2024

Description
In this PR I am moving the CSS for the hover style for the outline button variation to theme.json.
Note, I was not able to make it work with the > combinator so I removed it. Open for alternatives.

The PR also deletes the CSS file and the PHP function twentytwentyfive_block_stylesheets()

Closes #413

Testing Instructions

Add two buttons with the outline style variation, one with and one without a background color.
Add links to the buttons.
Hover over the button that does not have a background. Expected: The background color changes slightly.
Hover over the button that has a background color. Expected: The background does not change.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 28, 2024
@carolinan carolinan marked this pull request as ready for review September 28, 2024 00:34
Copy link

github-actions bot commented Sep 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended. labels Sep 28, 2024
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carolina, it is working well to me 🚀

Screen.Recording.2024-09-28.at.10.37.32.mov

I believe we don't need the combinator to add such specificity. It should work well with these changes, as the CSS is specific enough.

@carolinan carolinan merged commit b438c3b into trunk Sep 28, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom outline button styles
2 participants