Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Update pattern filenames, and titles #442

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

jasmussen
Copy link
Contributor

Description

Starts work at, maybe fixes #244. This PR does three things:

  1. It renames pattern filenames according to the proposed format here.
  2. It updates pattern slugs to reference match the filenames, and updates any includes to point to the new slugs.
  3. It updates titles to use numbers instead of text (3 columns instead of three columns), sentence case instead of titlecase, and comma instead of a colon for prefixes.

This needs a good bit of testing to see that patterns work and notably item 2, to make sure I've captured every template that includes other patterns with the correct slug.

Feel free to push changes to this PR.

Copy link

github-actions bot commented Sep 27, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Sep 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joen! Works well for me. I found a few tiny things I'm going to push changes for.

* Slug: twentytwentyfive/instagram-grid
* Categories: media, featured
* Slug: twentytwentyfive/media-instagram-grid
* Categories: media, gallery, featured
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen
Copy link
Contributor Author

Pushed some "aligned" improvements, and added "Services, " as a prefix to the 3 columns.

@carolinan carolinan merged commit e03f07e into trunk Sep 27, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit patterns filenames
3 participants