Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Follow-up: Replace color names and slugs #438

Merged
merged 13 commits into from
Sep 27, 2024
Merged

Follow-up: Replace color names and slugs #438

merged 13 commits into from
Sep 27, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 27, 2024

Description
A follow up to #420

Testing Instructions

  • Due to its size, it may be easier to review this by commit first.
  • Preview templates and patterns and confirm that there are no block validation errors and that the colors are unchanged.

Copy link

github-actions bot commented Sep 27, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan marked this pull request as ready for review September 27, 2024 04:45
Copy link

github-actions bot commented Sep 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carolina. Looks good to me 👍

@jasmussen jasmussen self-requested a review September 27, 2024 07:29
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some spot testing, and this is working well for me too:

colors

styles

@jasmussen
Copy link
Contributor

Thank you!

@carolinan carolinan merged commit 46ee1d3 into trunk Sep 27, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants