-
Notifications
You must be signed in to change notification settings - Fork 127
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks, Joen! I like the names, thank you for coming up with the alternatives. The only one that, I personally think could be different is "Display". It's subjective, but I'm biased because that wouldn't translate well or have a clear representation in Spanish. From the alternatives you shared, I prefer "Primary" and "Headline" instead of "Display". The only caveat for Primary is that we already use it for a color in the color palette, and maybe the expectation from some users is that the text style has indeed the primary color. Annotation and overline work well, in my opinion. I don't have a particular preference for that one; both work well. |
To me, headline has an even stronger association to being the most important heading on a page than both heading and title, and I don't think it should be used to style a paragraph. |
I'm cool with what @joen has proposed here. Let's move this forward, then perhaps circle back to adjust. It's critical to get type into a system that works, then we can rename to whatever we feel is best afterwards. |
"blockTypes": ["core/heading", "core/paragraph"], | ||
"styles": { | ||
"typography": { | ||
"fontSize": "var:preset|font-size|xx-large", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting these sizes may have to be one-off sizes once we pull this into #422 and evaluate properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for both display and subtitle
Okay, I checked with Juanfra. Let's merge this and then revisit if it becomes necessary. |
Description
Alternative to #330 and #388.
Adds two new text styles, Display and Subtitle, and renames "Pill" to "Annotation", as discussed here. Happy to update "Annotation" further, depending on your feedback.
The reason this is a separate PR is that this includes only the .json files, and no pattern changes. We can explore those changes separately depending on first landing this.
Penny for your thoughts! 🙏