Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Alt: Just the new text-styles #432

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Alt: Just the new text-styles #432

merged 1 commit into from
Sep 26, 2024

Conversation

jasmussen
Copy link
Contributor

Description

Alternative to #330 and #388.

Adds two new text styles, Display and Subtitle, and renames "Pill" to "Annotation", as discussed here. Happy to update "Annotation" further, depending on your feedback.

The reason this is a separate PR is that this includes only the .json files, and no pattern changes. We can explore those changes separately depending on first landing this.

Penny for your thoughts! 🙏

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Sep 26, 2024
@jasmussen jasmussen self-assigned this Sep 26, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Sep 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jasmussen jasmussen mentioned this pull request Sep 26, 2024
@juanfra
Copy link
Member

juanfra commented Sep 26, 2024

Thanks, Joen!

I like the names, thank you for coming up with the alternatives. The only one that, I personally think could be different is "Display". It's subjective, but I'm biased because that wouldn't translate well or have a clear representation in Spanish.

From the alternatives you shared, I prefer "Primary" and "Headline" instead of "Display". The only caveat for Primary is that we already use it for a color in the color palette, and maybe the expectation from some users is that the text style has indeed the primary color.

Annotation and overline work well, in my opinion. I don't have a particular preference for that one; both work well.

@carolinan
Copy link
Contributor

To me, headline has an even stronger association to being the most important heading on a page than both heading and title, and I don't think it should be used to style a paragraph.

@richtabor
Copy link
Member

Adds two new text styles, Display and Subtitle, and renames "Pill" to "Annotation", as discussed #388 (comment). Happy to update "Annotation" further, depending on your feedback.

I'm cool with what @joen has proposed here. Let's move this forward, then perhaps circle back to adjust. It's critical to get type into a system that works, then we can rename to whatever we feel is best afterwards.

"blockTypes": ["core/heading", "core/paragraph"],
"styles": {
"typography": {
"fontSize": "var:preset|font-size|xx-large",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting these sizes may have to be one-off sizes once we pull this into #422 and evaluate properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for both display and subtitle

@jasmussen
Copy link
Contributor Author

Okay, I checked with Juanfra. Let's merge this and then revisit if it becomes necessary.

@jasmussen jasmussen merged commit 1b4ac68 into trunk Sep 26, 2024
7 of 8 checks passed
@juanfra juanfra deleted the try/alt-text-styles branch September 26, 2024 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants