Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Add pattern: Overlap Images With Paragraph #364

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Add pattern: Overlap Images With Paragraph #364

merged 10 commits into from
Sep 19, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 18, 2024 •
edited
Loading

Description
This PR replaces #252 since the contributor is unavailable.
Because the original PR is on a branch on a fork, moving it to this repository will make it easier to edit for other contributors.

Fixes: #64
Figma: https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=3177-1817&t=UAEPVUr1BaR1QF5S-0

Screenshots
Mobile:

66 local__p=1856

Testing Instructions
Add the pattern.
Preview the pattern on different browser widths.
Confirm that the pattern matches the design.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta [email protected]
Co-authored-by: juanfra [email protected]
Co-authored-by: carolinan [email protected]
Co-authored-by: beafialho [email protected]
Co-authored-by: hanneslsm [email protected]

@carolinan carolinan marked this pull request as ready for review September 18, 2024 04:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: hanneslsm <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the [Priority] High Used to indicate top priority items that need quick attention label Sep 18, 2024
juanfra
juanfra approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carolina, looks good to me!

patterns/overlap-images-and-paragraph.php
<!-- /wp:heading -->
</div>
<!-- /wp:group -->
<!-- wp:paragraph {"style":{"typography":{"lineHeight":"1.2"}},"fontSize":"x-large"} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a good candidate for the new variation, if we merge that.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

beafialho
beafialho reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@beafialho beafialho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just left a couple comments on the naming of the pattern, which is incorrect.

Please also update the name of the pattern group:

Captura de ecrã 2024-09-18, às 10 59 28

patterns/overlap-images-and-paragraph.php Outdated
@@ -0,0 +1,49 @@
<?php
/**
* Title: Overlap images and paragraph on right
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say "Overlapping" instead of "overlap"

patterns/overlap-images-and-paragraph.php Outdated
* Title: Overlap images and paragraph on right
* Slug: twentytwentyfive/overlap-images-and-paragraph
* Categories: about, media, text
* Description: A section with overlap images, and a description.
Copy link
Contributor

@beafialho beafialho Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should say "Overlapping" instead of "overlap"

@juanfra juanfra merged commit da92614 into trunk Sep 19, 2024
4 checks passed
@juanfra juanfra deleted the add/pattern-overlap-images branch September 19, 2024 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanfra juanfra juanfra approved these changes

@beafialho beafialho beafialho left review comments

Assignees
No one assigned
Labels
[Component] Block Patterns [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block Patterns - About - Overlapping images and paragraph on the right
4 participants
@carolinan @juanfra @beafialho @shail-mehta