-
Notifications
You must be signed in to change notification settings - Fork 127
Add <main> to "Offset post without featured image" #318
Conversation
Indent the blocks in the file to improve the readability of the code.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I found a couple of is-style-default
appearances that we may want to remove now.
It looks like there were many changes to the file, but that is mostly because of the indentation. I removed To do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks Carolina!
For i18n, I've added this PR that will probably help us with that.
Regarding reusing the post pagination pattern, I believe we could tackle that in a separate template, and do it in all the templates where it's needed.
I found that the spacing is different between the post navigation in this pattern and in the the post navigation pattern. |
Description
Adds the
<main>
HTML tag to the pattern. All templates must include a main, both because all content needs to be inside a landmark, but also because in block themes, the automated skip link requires it.Indent the blocks in the file to improve the readability of the code.
Partial for #278
Screenshots
Testing Instructions
Apply the PR and go to Appearance > Editor > Templates.
Select the single post template.
In the settings sidebar, open the Template tab.
Open the Design panel and select the "Offset post without featured image" design.
Open the list view.
Select the group block that is between the header and footer.
In the block settings sidebar, open the Advanced panel.
Confirm that main is selected in the HTML element option.
Save.
View a single post on the front.
Confirm that there are no issues with the layout, the template should look identical before and after adding the main.