Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Rename primary/secondary/opacity colors to accents #420

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

EvanHerman
Copy link
Contributor

Resolves #415

Description

As mentioned in the original issue, it is not clear what significance the Primary, Secondary and Opacity colors have and should actually be accent colors. This PR changes the Primary color to Accent 4, Secondary to Accent 5 and Opacity to Accent 6.

Screenshots

image image image

Testing Instructions

  • Edit the global styles.
  • Click on 'Palette'.
  • Hover over each color to see their name appear in a tooltip.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Sep 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: EvanHerman <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@richtabor
Copy link
Member

@EvanHerman we'll need to do the same in the style variations within /styles/*

@carolinan carolinan merged commit 182785d into WordPress:trunk Sep 27, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change primary and secondary color slugs to "accent" colors
3 participants