Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Remove custom outline button styles #413

Closed
richtabor opened this issue Sep 25, 2024 · 3 comments · Fixed by #447
Closed

Remove custom outline button styles #413

richtabor opened this issue Sep 25, 2024 · 3 comments · Fixed by #447
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@richtabor
Copy link
Member

We should use theme.json to style variations instead. Otherwise it complicates how styles are accounted for.

.wp-block-button.is-style-outline
	> .wp-block-button__link:not(.has-text-color, .has-background):hover {
	background-color: var(--wp--preset--color--contrast, transparent);
	color: var(--wp--preset--color--base);
	border-color: var(--wp--preset--color--contrast, currentColor);
}

@richtabor richtabor added the [Type] Bug An existing feature does not function as intended. label Sep 25, 2024
@carolinan
Copy link
Contributor

Yes this is in progress.

@carolinan
Copy link
Contributor

I think this is part of #414. / #407

@richtabor
Copy link
Member Author

I'm questioning if this is necessary to include as a separate stylesheet here. If we're ok accepting the complexity with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants