This repository has been archived by the owner on May 23, 2018. It is now read-only.
remove BIND functionality for customizer in javascript #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to bind changed values in JavaScript to see changes instantly as we set `postMessage` for `.site-title` and `.site-description` to `selective_refresh` in the file `inc/customizer.php` on line `110` and `115`
and the following line of code will return `true` every time it get called
`if ( isset( $wp_customize->selective_refresh ) ) {` customizer.php on line 109
the reason why it returns true is that this theme will only be available in `WordPress 4.4-alpha` or later according to this back-compatibility check in `functions.php` on line 31
`if ( version_compare( $GLOBALS['wp_version'], '4.4-alpha', '<' ) ) {`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to bind changed values in JavaScript to see changes instantly as we set
postMessagefor.site-titleand.site-descriptiontoselective_refreshin the fileinc/customizer.phpon line110and115and the following line of code will return
trueevery time it get calledif ( isset( $wp_customize->selective_refresh ) ) {in customizer.php on line 109the reason why it returns true is that this theme will only be available in
WordPress 4.4-alphaor later according to this back-compatibility check infunctions.phpon line 31if ( version_compare( $GLOBALS['wp_version'], '4.4-alpha', '<' ) ) {