Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with better error messaging. #19

Merged
merged 5 commits into from
Mar 16, 2021

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Mar 8, 2021

This PR introduces an error readme file with information about each UI test.

Ideally, the readme only defines what the test does and leaves the actual information within the current handbooks.

Hoping to address:
WordPress/wordpress.org#26 (comment)

@carolinan
Copy link
Contributor

This is better, it is still unclear:

  • Which of the outputted messages are required according to theme directory requirements
  • Which are recommendations
  • What is the theme authors next step?

What is an unexpected link?

The menu check is incorrect. I don't think that belongs in this issue though:
Opening a sub menu on hover must not be required. Hovering is the least accessible way. It should not even be mentioned as recommended.

@StevenDufresne
Copy link
Contributor Author

This is better, it is still unclear:

Which of the outputted messages are required according to theme directory requirements
Which are recommendations
What is the theme authors next step?

These are fair questions. I'll keep them top of mind.

The menu check is incorrect. I don't think that belongs in this issue though:
Opening a sub menu on hover must not be required. Hovering is the least accessible way. It should not even be mentioned as recommended.

Responded in the associated issue: #20.

What is an unexpected link?

https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

@StevenDufresne StevenDufresne changed the title [WIP] Experiment with better error messaging. Experiment with better error messaging. Mar 16, 2021
@StevenDufresne
Copy link
Contributor Author

I'm going to merge this for now, but @carolinan points out some higher-level questions that will need answering. Roughly logged in #21.

@StevenDufresne StevenDufresne merged commit 0fedb20 into trunk Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants