-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Storybook and pin Nuxt Storybook module version #5025
Conversation
91443f4
to
d83672a
Compare
d83672a
to
b3f7b9b
Compare
Latest k6 run output1
Footnotes
|
81254a6
to
d5dffda
Compare
d5dffda
to
e5fd58c
Compare
Full-stack documentation: https://docs.openverse.org/_preview/5025 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
2e823c0
to
dd9e2e7
Compare
dd9e2e7
to
b5afb66
Compare
0449c78
to
8377741
Compare
8377741
to
972f6f1
Compare
1cdd85a
to
3f6eb1a
Compare
9c295d1
to
f3f8922
Compare
d699003
to
9bf3814
Compare
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @dhruvkb Excluding weekend1 days, this PR was ready for review 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
9bf3814
to
eedff74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to be back on a stable version instead of nightly.
eedff74
to
236c178
Compare
Fixes
Fixes #4963 by @sarayourfriend
Description
Now that the Nuxt Storybook module has released a stable release that works with Openverse, we can pin its version, and update the module's dependencies to match it.
TLDR; Updating the node version and removing
node_modules
volume from playwright docker-compose definition fixed the Storybook build problems in the CI, without making the tests run longer.More detailed description of the build problems
Unfortunately, the changes in Storybook v8.3.0-alpha.4 made it so that a wrong version of
ufo
file is being required (.mjs
instead of.cjs
), probably by thenuxt-link.js
in storybook nuxt module, and this throws anunexpected identifier export
error. I couldn't find a way of fixing this as there seems to be layers upon layers of rewriting/hijackingrequire
.The best solution I found here for now was to pin Storybook at v8.3.0-alpha.3.When I tried to debug the issues, I ran
storybook build
locally, withoutov
. This time, I didn't see the build issue, and noticed that my local version of Node is different than what we have inpackage.json
engines. This is why I updated the Node version, and updated the Storybook versions to the latest versions here.It still seems to be failing if we keep using the local pnpm folder as a volume. When I removed it in this PR, the Storybook build in CI was fixed.
This PR also sets the default port for Storybook in dev mode to match that of the production mode.
Testing Instructions
The Storybook tests in the CI should pass.
Run
ov just frontend/run dev
. This should run the Storybook in dev mode athttp://localhost:54000
.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin