Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test from #4995 #4999

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix flaky test from #4995 #4999

merged 2 commits into from
Sep 27, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 26, 2024

Fixes

Fixes #4995 by @sarayourfriend

Description

Fixes the test by adding a check for the copy button: it is only enabled after the app has finished hydrating.

A different test (checking the preferences switch sets the cookie value) was found as flaky, so I added a check to that test as well.

Testing Instructions

The CI should pass (several times?)

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner September 26, 2024 18:45
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.8 GB  8.5 MB/s
     data_sent......................: 1.0 MB  4.9 kB/s
     http_req_blocked...............: avg=7.58µs   min=1.29µs  med=2.47µs   max=4.84ms  p(90)=3.55µs   p(95)=3.88µs  
     http_req_connecting............: avg=4.5µs    min=0s      med=0s       max=4.79ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=555.39ms min=27.47ms med=496.07ms max=2.37s   p(90)=1.04s    p(95)=1.15s   
       { expected_response:true }...: avg=555.39ms min=27.47ms med=496.07ms max=2.37s   p(90)=1.04s    p(95)=1.15s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=156.14µs min=36.92µs med=112.26µs max=19.41ms p(90)=184.27µs p(95)=234.03µs
     http_req_sending...............: avg=22.84µs  min=7.23µs  med=19.65µs  max=3.94ms  p(90)=26.63µs  p(95)=33.11µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=555.21ms min=27.33ms med=495.86ms max=2.37s   p(90)=1.04s    p(95)=1.15s   
     http_reqs......................: 8000    37.373823/s
     iteration_duration.............: avg=3.71s    min=1.17s   med=3.16s    max=11.41s  p(90)=8.1s     p(95)=8.61s   
     iterations.....................: 1200    5.606073/s
     vus............................: 2       min=2       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat merged commit d4e8465 into main Sep 27, 2024
46 checks passed
@obulat obulat deleted the fix/#4995 branch September 27, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Playwright e2e test e2e/attribution.spec.ts:52:7 › attribution › can copy HTML attribution is flaky
3 participants