Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove steps for unprepared k6 after staging frontend deploy #4990

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Fast follow to #4924.

Description

The linked Pr accidentally included steps in the staging deploy job that weren't validated or ready yet.

Testing Instructions

N/A, merge this to fix failing staging deploy jobs.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: mgmt Related to repo management and automations labels Sep 25, 2024
@sarayourfriend sarayourfriend requested a review from a team as a code owner September 25, 2024 18:20
@sarayourfriend sarayourfriend requested review from AetherUnbound and stacimc and removed request for a team September 25, 2024 18:20
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to enable deployment.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just code removed. LGTM.

Copy link

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.8 GB  8.4 MB/s
     data_sent......................: 1.0 MB  4.9 kB/s
     http_req_blocked...............: avg=9.74µs   min=1.32µs  med=2.62µs   max=5.02ms  p(90)=3.72µs   p(95)=4.1µs   
     http_req_connecting............: avg=5.9µs    min=0s      med=0s       max=4.95ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=558.99ms min=28.25ms med=500.13ms max=2.36s   p(90)=1.04s    p(95)=1.15s   
       { expected_response:true }...: avg=558.99ms min=28.25ms med=500.13ms max=2.36s   p(90)=1.04s    p(95)=1.15s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=152.51µs min=39.64µs med=112.35µs max=16.59ms p(90)=183.78µs p(95)=226.94µs
     http_req_sending...............: avg=22.63µs  min=7.51µs  med=19.98µs  max=3.4ms   p(90)=26.86µs  p(95)=32.95µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=558.82ms min=28.15ms med=499.91ms max=2.36s   p(90)=1.04s    p(95)=1.15s   
     http_reqs......................: 8000    37.025536/s
     iteration_duration.............: avg=3.73s    min=1.03s   med=3.13s    max=11.9s   p(90)=8s       p(95)=8.54s   
     iterations.....................: 1200    5.55383/s
     vus............................: 4       min=4       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@sarayourfriend sarayourfriend merged commit ade3169 into main Sep 25, 2024
81 checks passed
@sarayourfriend sarayourfriend deleted the remove/errant-staging-k6-steps branch September 25, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: mgmt Related to repo management and automations
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

3 participants