Add correct verbose_name and verbose_name_plural to Audio, DeletedAudio, and SensitiveAudio models

[dryruffian]

Fixes

Fixes #4655 by @dhruvkb

Description

This PR addresses the issue of missing or incorrect verbose_name and verbose_name_plural values for audio-related models. The changes improve the Django admin interface experience by providing more accurate and consistent labeling for these models, as specified in the issue description.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[krysal]

This is looking good. For tests to pass you just need to generate and include the migrations associated to these changes that Django creates. Run the following and commit the changes:

1. ov just api/dj makemigration
2. ov just api/dj migrate

The migration would be no-op, you can check doing ov just api/dj sqlmigrate api 0071, but they are still required.

Expected output

BEGIN;
--
-- Change Meta options on audio
--
-- (no-op)
--
-- Change Meta options on deletedaudio
--
-- (no-op)
--
-- Change Meta options on sensitiveaudio
--
-- (no-op)
COMMIT;

[dryruffian]

This Change can fix issue #4974

[sarayourfriend]

The overall fix required broader changes, which I've got in this PR: #4992

You can rebase this PR on that one, or wait for that one to be merged (hopefully it will go in soon given the criticality of it to the development environment).

[dryruffian]

Hi @krysal,
Thank you for the suggestion. I've made the suggested changes. Please review my PR and let me know if you have any further suggestions.

[sarayourfriend]

This LGTM, I'll go ahead and removed the change to the env.docker file in favour of #4992 which has a broader fix and then merge.

[sarayourfriend]

I wonder what introduced this ordering change? 🤔 And why it wasn't present before. Image has had it since migration 0.

Changes addressed

[sarayourfriend]

@dryruffian I've rebased your branch to try to fix that failing API test.

[sarayourfriend]

~@dhruvkb would you be able to lend a hand with debugging why the permission group might not be available in load_sample_data? I can't make out any reason why this PR should have any effect on that 🤔 ~

Never mind! @dryruffian you'll need to update the load_sample_data script to use the new correct names of the models when identifying the permission groups.

In fact, however, I am worried that this will break existing permissions in production. @dhruvkb can you help review this and see whether it will cause a problem downstream if we change the verbose name of the model? IIRC we have code that manually builds the permission checks in the media moderation admin.

[dryruffian]

Thanks @sarayourfriend,
I will add the suggested changes

[dryruffian]

Hi @sarayourfriend,
I've run ov just api/init on my local machine, and it's working fine. However, the API test is failing in a similar stage, and I don't know why. The "Migration Safety Check / Check and Apply Labels" (pull request) is failing. Can you please help me troubleshoot this?

[sarayourfriend]

Yes, as I said, because this PR changes the name of the model, the name of the permission is no longer the same as it was before.

We can fix this by using a part of the permission object that is constant, the codename. Here is a diff to apply to do that:

diff --git a/load_sample_data.sh b/load_sample_data.sh
index cd5f195a3..a67d3b4c4 100755
--- a/load_sample_data.sh
+++ b/load_sample_data.sh
@@ -101,9 +101,9 @@ if created:
   print('Setting up Content Moderators group')
   for model, perms in model_perms_map.items():
     for perm in perms:
-      name = f'Can {crud_perm_map[perm]} {model}'
+      name = f'{crud_perm_map[perm]}_{model}'
       print(f'Adding permission to moderators group: {name}')
-      model_add_perm = Permission.objects.get(name=name)
+      model_add_perm = Permission.objects.get(codename=name)
       mod_group.permissions.add(model_add_perm)
   mod_group.save()
   mod_group.user_set.add(User.objects.get(username='moderator'))

[sarayourfriend]

You can ignore the failure on the migration safety warning; it will not complete on forks. It isn't a required request, so don't worry about it, it won't block merging the PR.

[dryruffian]

Hi @dhruvkb, I've fixed all the tests in this PR. Please review my changes and let me know if you have any further suggestions.