-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the homepage dark color #4983
Open
obulat
wants to merge
1
commit into
main
Choose a base branch
from
update/dark_homepage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🧱 stack: frontend
Related to the Nuxt frontend
🟧 priority: high
Stalls work on the project or its dependents
✨ goal: improvement
Improvement to an existing user-facing feature
🖼️ aspect: design
Concerns related to design
labels
Sep 24, 2024
obulat
force-pushed
the
update/dark_homepage
branch
from
September 24, 2024 14:06
78511f9
to
cc80665
Compare
zackkrida
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Barring any design changes from @fcoveram, I think this looks great!
obulat
force-pushed
the
update/dark_homepage
branch
from
September 25, 2024 06:14
cc80665
to
bc161e4
Compare
obulat
force-pushed
the
update/dark_homepage
branch
from
September 25, 2024 07:34
bc161e4
to
ebc00c3
Compare
@obulat looks like potential flake in an audio test |
obulat
force-pushed
the
update/dark_homepage
branch
2 times, most recently
from
September 25, 2024 15:52
c2ad110
to
f9c7946
Compare
obulat
force-pushed
the
update/dark_homepage
branch
from
September 27, 2024 04:14
f9c7946
to
6dedd69
Compare
Latest k6 run output1
Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🖼️ aspect: design
Concerns related to design
✨ goal: improvement
Improvement to an existing user-facing feature
🟧 priority: high
Stalls work on the project or its dependents
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4936 by @fcoveram
Description
This PR changes the color of the homepage in dark mode to match the mockups. This also changes the color of the generic error page, you can see the updated version in the changed snapshots.
Testing Instructions
Run the app and go to http://localhost:8443
Change the app theme to dark
Check that the colors are correct, or suggest improvements.
Also check the error page by going to http://localhost:8443/non-existent-page. Note that this page's design will need to be updated, but in this PR only the colors are updated to match the home page.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin