Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the homepage dark color #4983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the homepage dark color #4983

wants to merge 1 commit into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 24, 2024

Fixes

Fixes #4936 by @fcoveram

Description

This PR changes the color of the homepage in dark mode to match the mockups. This also changes the color of the generic error page, you can see the updated version in the changed snapshots.

Testing Instructions

Run the app and go to http://localhost:8443
Change the app theme to dark
Check that the colors are correct, or suggest improvements.
Also check the error page by going to http://localhost:8443/non-existent-page. Note that this page's design will need to be updated, but in this PR only the colors are updated to match the home page.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner September 24, 2024 12:29
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 🖼️ aspect: design Concerns related to design labels Sep 24, 2024
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring any design changes from @fcoveram, I think this looks great! :shipit:

@obulat obulat requested review from fcoveram and removed request for dhruvkb September 25, 2024 07:23
@obulat obulat self-assigned this Sep 25, 2024
@zackkrida
Copy link
Member

@obulat looks like potential flake in an audio test

@obulat
Copy link
Contributor Author

obulat commented Sep 25, 2024

@obulat looks like potential flake in an audio test

It's #4981. Working on it

@obulat obulat force-pushed the update/dark_homepage branch 2 times, most recently from c2ad110 to f9c7946 Compare September 25, 2024 15:52
Copy link

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.8 GB  8.7 MB/s
     data_sent......................: 1.0 MB  5.0 kB/s
     http_req_blocked...............: avg=9.7µs    min=1.18µs  med=2.27µs   max=5.38ms  p(90)=3.37µs   p(95)=3.63µs  
     http_req_connecting............: avg=6.89µs   min=0s      med=0s       max=5.3ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=547.63ms min=41.93ms med=490.81ms max=2.34s   p(90)=1.03s    p(95)=1.12s   
       { expected_response:true }...: avg=547.63ms min=41.93ms med=490.81ms max=2.34s   p(90)=1.03s    p(95)=1.12s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=132.8µs  min=39.18µs med=106.53µs max=12.97ms p(90)=176.24µs p(95)=217.27µs
     http_req_sending...............: avg=21.21µs  min=6.34µs  med=18.9µs   max=2.98ms  p(90)=25.69µs  p(95)=31.45µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=547.48ms min=41.85ms med=490.7ms  max=2.34s   p(90)=1.03s    p(95)=1.12s   
     http_reqs......................: 8000    37.930302/s
     iteration_duration.............: avg=3.65s    min=1.16s   med=3s       max=12.16s  p(90)=7.85s    p(95)=8.34s   
     iterations.....................: 1200    5.689545/s
     vus............................: 2       min=2       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

Darker homepage in dark theme
3 participants