Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify amd64 platform to fix ov builds on macOS #4932

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Specify amd64 platform to fix ov builds on macOS #4932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker/dev_env/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ shared_args=(
run_args=(
-d
--name "$container_name"
# Since we have build an amd64 image, we must specify the platform to
# suppress warnings about platform mismatch.
--platform linux/amd64
# Use host network so things like Sphinx and the frontend that run directly in `ov`
# will have ports available on the host (and this way we don't have to manually map each one)
--network host
Expand Down
3 changes: 2 additions & 1 deletion ov
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ init)
;;

build)
docker build "${@:2}" -t openverse-dev_env:latest "$dev_env"
# k6 does not install on aarch64, so we must specify the platform on macOS.
docker build "${@:2}" --platform linux/amd64 -t openverse-dev_env:latest "$dev_env"
;;

setup-env)
Expand Down
Loading