-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inverted CC icons for dark mode #4921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great 🚀
While running dev, I noticed that the switcher's popover is broken. I stop and run dev twice and still see it. CleanShot.2024-09-13.at.10.28.17.mp4It has nothing to do with this PR, but wondering if you also see this to report it in a new issue. |
I was reading about optimizing SVG files for dev hands-off, and discovered SVGOMG. If you find that useful, I took the time to clean up all the icons. |
@fcoveram I already cleaned up the icons in this PR, albeit with a custom hacky Python script. We should definitely incorporate SVGOMG into our workflow. |
Fixes
Fixes #4909 by @fcoveram
Description
This PR adds inverted icons for CC licenses. A small cleanup was performed for the added SVGs (such as removing unnecessary attributes and merging paths).
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin