Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PDM available when linting in release app #4899

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Fixes this failure: https://github.com/WordPress/openverse/actions/runs/10782697007/job/29903186115

Description

Same issue that we found in #4866, but for the release GitHub workflow rather than CI/CD where we noticed it in the original PR.

I've searched for just lint in our GitHub Workflows and this is the only other one, I think.

Testing Instructions

Make sure I didn't miss other cases where Vale would run in GitHub Workflows where PDM would need to be available.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.
  • [N/A] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: mgmt Related to repo management and automations labels Sep 9, 2024
@sarayourfriend sarayourfriend requested a review from a team as a code owner September 9, 2024 23:17
@sarayourfriend sarayourfriend requested review from krysal and stacimc and removed request for a team September 9, 2024 23:17
Copy link
Collaborator

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think that should do it 👍

sarayourfriend added a commit that referenced this pull request Sep 9, 2024
Doing this manually due to failure in https://github.com/WordPress/openverse/actions/runs/10782697007/job/29903186115 fixed by #4899; but we do not need to create a new release just for the changelog file, so this works!
@sarayourfriend sarayourfriend mentioned this pull request Sep 9, 2024
6 tasks
@sarayourfriend sarayourfriend merged commit 3455662 into main Sep 9, 2024
67 checks passed
@sarayourfriend sarayourfriend deleted the fix/release-app-vale branch September 9, 2024 23:30
sarayourfriend added a commit that referenced this pull request Sep 9, 2024
* Add catalog changelog

Doing this manually due to failure in https://github.com/WordPress/openverse/actions/runs/10782697007/job/29903186115 fixed by #4899; but we do not need to create a new release just for the changelog file, so this works!

* Add missing page header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants