Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency vue to v3.4.38 #4771

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Update dependency vue to v3.4.38 #4771

merged 4 commits into from
Aug 20, 2024

Conversation

openverse-bot
Copy link
Collaborator

@openverse-bot openverse-bot commented Aug 16, 2024

This PR contains the following updates:

Package Type Update Change
vue (source) devDependencies patch 3.4.36 -> 3.4.38

Release Notes

vuejs/core (vue)

v3.4.38

Compare Source

For stable releases, please refer to CHANGELOG.md for details.
For pre-releases, please refer to CHANGELOG.md of the minor branch.

v3.4.37

Compare Source

For stable releases, please refer to CHANGELOG.md for details.
For pre-releases, please refer to CHANGELOG.md of the minor branch.


Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openverse-bot openverse-bot requested a review from a team as a code owner August 16, 2024 12:09
@openverse-bot openverse-bot added dependencies Pull requests that update a dependency file 💻 aspect: code Concerns the software code in the repository 🟨 tech: javascript Involves JavaScript 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Aug 16, 2024
@openverse-bot openverse-bot force-pushed the gha-renovatevue-monorepo branch 3 times, most recently from 32a49f4 to c761b08 Compare August 16, 2024 21:34
Copy link

This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced.

@openverse-bot openverse-bot force-pushed the gha-renovatevue-monorepo branch 2 times, most recently from 96c5f0b to a68a5bc Compare August 19, 2024 08:36
@obulat
Copy link
Contributor

obulat commented Aug 19, 2024

The ref types have changed, and now the type check is failing. This issue seems to be connected: vuejs/core#11548. @WordPress/openverse-frontend, any suggestions here?

@zackkrida
Copy link
Member

@obulat I think I've pushed the simplest fix which coerces the type of media in the use-collection composable, as a workaround for this issue with ref unwrapping.

@openverse-bot
Copy link
Collaborator Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Signed-off-by: Olga Bulat <[email protected]>
@obulat
Copy link
Contributor

obulat commented Aug 20, 2024

@obulat I think I've pushed the simplest fix which coerces the type of media in the use-collection composable, as a workaround for this issue with ref unwrapping.

I tried coercing the type in many places, but didn't even think of doing it after the computed :) I removed the other type casts since they are not used anyways.

@obulat obulat merged commit 5800758 into main Aug 20, 2024
43 checks passed
@obulat obulat deleted the gha-renovatevue-monorepo branch August 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants