Drop status column from media reports

[krysal]

Fixes

Fixes #3642 by @sarayourfriend

Description

As title says, the column is removed, making the AbstractMediaReport.STATUS_CHOICES unnecessary, so they're also removed.

Testing Instructions

Try creating a new report to confirm it still works.

curl --request POST \
  --url http://localhost:50280/v1/images/<uuid>/report/ \
  --header 'Content-Type: application/json' \
  --data '{
	"reason": "[dmca|mature|other]",
	"description": "Test"
}'

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• [N/A] I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• [N/A] I ran the DAG documentation generator (./ov just catalog/generate-docs for catalog PRs) or the media properties generator (./ov just catalog/generate-docs media-props for the catalog or ./ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[sarayourfriend]

LGTM, except there are usages of status and the status choice constants that we should also remove.

If you search for status= in test_media_report.py there are three more related to the report factory usage that should be removed.

After that it should be possible to also remove the status choices constants from api/models/media.py.

[sarayourfriend]

I suppose this can also be assert report.is_pending, to be more directly relevant to the previous expression.

[krysal]

Good observation! Changes applied.

[sarayourfriend]

Looks like this might have gotten mixed up in commits? Left a comment with suggested change.

[sarayourfriend]

LGTM! Looks like maybe a small mix up with commits and a commented assertion, but an easy fix and non-blocker really.

[sarayourfriend]

Looks like this might have gotten mixed up in commits? Left a comment with suggested change.

[stacimc]

LGTM, other than the comment Sara noticed 👍

[github-actions]

This PR has migrations. Please rebase it before merging to ensure that conflicting migrations are not introduced.