Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content report popover appears over the pages modal #569

Closed
1 task
krysal opened this issue Apr 29, 2022 · 6 comments
Closed
1 task

Content report popover appears over the pages modal #569

krysal opened this issue Apr 29, 2022 · 6 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@krysal
Copy link
Member

krysal commented Apr 29, 2022

Reproduction

  1. Go to a result page on mobile and open the content report popover.
  2. Then open the pages modal by clicking the three dots button in the header. The content report popover will appear over the modal. It should close due to "click outside".

Screenshots

photo_2022-04-29 15 48 30

Environment

  • Device: Phone

Additional context

Originally reported by @sarayourfriend. Possibly related to WordPress/openverse-frontend#1280.

Resolution

  • 🙋 I would be interested in resolving this bug.
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🖼️ aspect: design Concerns related to design labels Apr 29, 2022
@obulat obulat added 🕹 aspect: interface Concerns end-users' experience with the software and removed 🖼️ aspect: design Concerns related to design labels Aug 25, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@zackkrida
Copy link
Member

Oh dear. Although we no longer have a pages menu on mobile, this appears to have remained with the content switcher:

CleanShot 2023-02-22 at 10 17 46

@obulat
Copy link
Contributor

obulat commented Mar 1, 2023

We have specifically disabled closing the report form popover on click outside. Is it better to reverse this, or to update the z-index of either the content switcher modal or the report popover? We need the content switcher modal to be below the license explanation popover, so we can't make its z-index too high.

@zackkrida
Copy link
Member

My opinion would be that we shift the z indexes around so the drawer is above the reporting form.

@obulat
Copy link
Contributor

obulat commented Aug 11, 2023

Currently, clicking outside the report popover has no effect at all. So, you cannot open a pages modal at all, if the report popover is open.
We need to update the report popover to be similar to the meta search modal on the mobile as in #460

@obulat obulat added the design: needed Needs a designer's touch before implementation can begin label Aug 11, 2023
@fcoveram
Copy link
Contributor

This problem was addressed in #3582, so replacing the design: needed label with design: ready

@fcoveram fcoveram added design: ready Issue with a mockup ready for implementation and removed design: needed Needs a designer's touch before implementation can begin labels May 20, 2024
@obulat
Copy link
Contributor

obulat commented Sep 30, 2024

Fixed by #4800

@obulat obulat closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants