-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal popover for report and license definition #3582
Comments
Subscribe to Label Actioncc @WordPress/gutenberg-design, @WordPress/openverse
This issue or pull request has been labeled: "🖼️ aspect: design"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
FWIW I agree that the additional context in v2 makes a lot of sense to me. As a bonus, it would also reduce the number of visual changes happening on the screen as you click into each license popover and back to the filters. |
The mockups for v2 (Push the drawer behind the modal opaque layer) were updated with the latest changes and are ready for dev. |
This looks great, thank you @fcoveram |
Blocked by the code freeze during Nuxt 3 migration. |
Problem
As reported in #569, reporting content is currently made from a popover that looks broken on small screens. Based on the recent Design Library updates, we can improve this, and also the license definition popover, by reusing the component merged in #2860
Issues related
Proposal
Search results page
Since the license description element is toggled from the drawer in small screens, I have two ideas that I would like your thoughts on.
v1. Replace drawer with the license
In this first version, once you click on the license’s question icon, the drawer disappears and is replaced by the license popover. You can see how the results grid is visible behind the modal layer.
v2. Push the drawer behind modal opaque layer
The second idea is to push the drawer behind the modal layer to avoid losing the context of where users displayed the info from. See how the drawer remains behind the dark layer.
I am more drawn to this version as contexts in modals play a key role.
From
LG
and beyondOn bigger screens, the license description popover is displayed as in the current flow.
Single result page
In the single result page, the popover shows up as in the current flow.
Popovers
As described in #2860, the following specs are still valid:
xs
, horizontal margins24px
However, I noticed that we did not consider a scrollable popover for those cases where its height overflows the device screen. For that case, I tried the following:
The spacings mirror the ones applied to the current component, but instead of wrapping the content with a single element, the popover's header is separated to keep it sticky when scrolling down. Below a screenshot of dev mode.
Mockups
Figma file: Modal popover for report and license definition
The text was updated successfully, but these errors were encountered: