Replace span with h2 on image search results (#1888)

* Replace span with h2 for image results
WordPress · May 2, 2023 · a97a8d7 · a97a8d7
1 parent 6ed3daf
commit a97a8d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/frontend/src/components/VSearchResultsGrid/VImageCell.vue b/frontend/src/components/VSearchResultsGrid/VImageCell.vue
@@ -31,7 +31,7 @@
       <figcaption
         class="invisible absolute bottom-0 left-0 bg-white p-1 text-dark-charcoal group-hover:visible group-focus:visible"
       >
-        <span class="sr-only">{{ image.title }}</span>
+        <h2 class="sr-only">{{ image.title }}</h2>
         <VLicense :license="image.license" :hide-name="true" />
       </figcaption>
     </figure>

diff --git a/frontend/test/unit/specs/components/related-images.spec.js b/frontend/test/unit/specs/components/related-images.spec.js
@@ -38,9 +38,10 @@ describe("RelatedImage", () => {
   it("should render an image grid", () => {
     render(VRelatedImages, options)
 
-    expect(screen.getByRole("heading").textContent).toContain(
+    expect(screen.getAllByRole("heading")[0].textContent).toContain(
       "image-details.related-images"
     )
+    expect(screen.queryAllByRole("heading").length).toEqual(3)
     expect(screen.queryAllByRole("img").length).toEqual(2)
     expect(screen.queryAllByRole("figure").length).toEqual(2)
   })