Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: Add border style support #69401

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Mar 4, 2025

What?

In these two uses there is a suggestion to revisit the decision to exclude the border style option from the image block.

#47401
#43247

The decision to exclude the border style was made in 2021.
#31366 (comment)

This PR adds the border style to block.json of the image block.

Testing Instructions

Test the border style options with different image block settings and when the image block:

  1. is a placeholder
  2. is nested
  3. is linked
  4. has lightbox enabled
  5. is aligned
  6. has duotone
  7. has the rounded block style applied

Style the block both from the Styles sidebar in the Site Editor and in the block editor.

Confirm that the border style is inline on the block.

@carolinan carolinan added [Type] Enhancement A suggestion for improvement. [Block] Image Affects the Image Block labels Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant