Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Query Block Filtering by Taxonomies having non_queryable as false. #69398

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

Vedant-Gandhi
Copy link

@Vedant-Gandhi Vedant-Gandhi commented Mar 4, 2025

What?

This PR allows the Query Block to be filtered with the taxonomies having non_queryable as false.

Why?

Reference Issue: #60301

How?

I have added an extra option to maintain backwards compatibility with the recent change introduced to disallow non-Queryable Taxonomies. My implementation follows a whitelisting approach where we can pass allowPubliclyQueryable to the useTaxonomies hook.

Testing Instructions

  1. Ensure you have registered a custom taxonomy with non_queryable as false and bind it to your post type that will be used in the following step in Query Block.
  2. Add a query loop block in the post.
  3. Select the filters and go to taxonomies.
  4. Ensure the custom taxonomy appears there.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Vedant-Gandhi! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Vedant-Gandhi Vedant-Gandhi marked this pull request as ready for review March 4, 2025 05:36
Copy link

github-actions bot commented Mar 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vedant-Gandhi <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Query Loop Affects the Query Loop Block labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants