-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Missing Trailing periods in Experiment Settings Page #69395
Added Missing Trailing periods in Experiment Settings Page #69395
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the Review. |
The one e2e test failure is a known issue (#69392). I'm not sure about the other. Can you double check if this string isn't used in any e2e tests. |
Maybe it might be related to the recent core changes. See #69403 |
I have checked in code and found string is not used in any other places, so might be its failing because of core changes #69403 |
34897c5
to
0047575
Compare
Flaky tests detected in 0047575. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13678975138
|
What?
This PR adding the trailing period in the Experiment Settings Page
Why?
Modified the
Experiment Settings Page
to add the trailing period. This ensures consistency in theExperiment Settings Page
.Testing Instructions
Blocks: disable TinyMCE and Classic block
OptionDisables the TinyMCE and Classic block
has missing trailing periodScreenshots