Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Missing Trailing periods in Experiment Settings Page #69395

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Mar 3, 2025

What?

This PR adding the trailing period in the Experiment Settings Page

Why?

Modified the Experiment Settings Page to add the trailing period. This ensures consistency in the Experiment Settings Page.

Testing Instructions

  1. Open Experimental Settings Page
  2. Go to Blocks: disable TinyMCE and Classic block Option
  3. See for Disables the TinyMCE and Classic block has missing trailing period

Screenshots

Before After
image image

@shail-mehta shail-mehta added the [Type] Experimental Experimental feature or API. label Mar 3, 2025
@shail-mehta shail-mehta self-assigned this Mar 3, 2025
@shail-mehta shail-mehta marked this pull request as ready for review March 3, 2025 16:52
Copy link

github-actions bot commented Mar 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta requested a review from t-hamano March 3, 2025 17:11
@shail-mehta
Copy link
Member Author

Thanks for the Review.

@Mamaduka
Copy link
Member

Mamaduka commented Mar 4, 2025

The one e2e test failure is a known issue (#69392). I'm not sure about the other. Can you double check if this string isn't used in any e2e tests.

@t-hamano
Copy link
Contributor

t-hamano commented Mar 4, 2025

I'm not sure about the other.

Maybe it might be related to the recent core changes. See #69403

@shail-mehta
Copy link
Member Author

I have checked in code and found string is not used in any other places, so might be its failing because of core changes #69403

@shail-mehta shail-mehta force-pushed the add/missing-trailing-periods-in-experiment-page branch from 34897c5 to 0047575 Compare March 5, 2025 15:03
Copy link

github-actions bot commented Mar 5, 2025

Flaky tests detected in 0047575.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13678975138
📝 Reported issues:

@shail-mehta shail-mehta merged commit 46e88a4 into trunk Mar 5, 2025
59 checks passed
@shail-mehta shail-mehta deleted the add/missing-trailing-periods-in-experiment-page branch March 5, 2025 15:38
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants