Block Directory: Fix installations for 'template-locked' mode #69394
+68
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: +23 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Mar 4, 2025
|
Thanks for testing, @t-hamano! |
Mamaduka
added
the
Backport to WP 6.8 Beta/RC
Mamaduka
force-pushed
the
fix/block-directory-selectors
branch
from
3421c91 to
a1b2cb0
Compare
github-actions
bot
removed
the
Backport to WP 6.8 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Use stable reference fallback for getDownloadableBlocks * Do nothing when there are no installed block types * Update block directory selectors * Remove unused utility method and tests Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: karthikeya-io <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 68b1105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69360.
PR fixes the Block Directory installation bug when "Show Template" mode is enabled. The bug can be reproduced in older WP versions, but it has become more visible now that users can persist "Show Template" settings.
Why?
The block directory store uses blocks visible in content to finish or clean up installations. When rendering in
template-lockedmode, the content becomes nested inside the template, but directory selectors weren't adopted for this mode.How?
Use the
getClientIdsWithDescendantsselector to get all the blocks currently used in the editor.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast