Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Add transparency slider for submenu background #69379

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Mar 3, 2025

Closes: #53487

What?

This PR adds the ability to set a transparent background for Navigation Block submenus by enabling the alpha (transparency) channel in the color picker for the submenu background setting.

Why?

Currently, users who want their submenu background to be transparent (to match the transparent background of the navigation block) have to use custom CSS. When no background color is set, submenus default to a white background, and the existing color picker doesn't allow for transparency settings.

This improvement creates a more intuitive user experience by allowing transparency to be set directly from the editor interface without requiring custom code.

How?

The implementation adds the enableAlpha: true property to the color settings for the submenu & overlay background in the ColorGradientSettingsDropdown component. This enables the transparency slider in the WordPress color picker component, allowing users to select any level of transparency for submenu backgrounds.

Testing Instructions

  1. Create a new page/post and add a Navigation Block
  2. Add a submenu item to the navigation
  3. In the sidebar, under the Color panel, find the "Submenu & overlay background" color setting
    Select a custom color
  4. Verify that a transparency/opacity slider is now available
  5. Adjust the transparency and check that the submenu background shows the correct transparency level

Screenshots or screencast

Before

Before.mov

After

After.mov

@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review March 4, 2025 05:02
Copy link

github-actions bot commented Mar 4, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Mar 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvikpatel18 <[email protected]>
Co-authored-by: cuemarie <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Block: Allow for transparent submenu background
2 participants