ColorPalette components: Changed Props from __experimentalIsRenderedInSidebar
to isRenderedLeftStart
#69376
+27
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I will correct it according to the comment in the PR below.
#69169 (comment)
Changed Props from
__experimentalIsRenderedInSidebar
toisRenderedLeftStart
Why?
__experimentalIsRenderedInSidebar
is not a good prop name, so change it toisRenderedLeftStart
.The names of the props are based on the placement.
gutenberg/packages/components/src/color-palette/index.tsx
Lines 149 to 161 in 4e3b759
I will migrate
__experimentalIsRenderedInSidebar
toisRenderedLeftStart
for components other thanpackages/format-library/src/text-color/inline.js
in a separate branch.How?
Testing Instructions