DataView Actions Modal: Allow customizable modal size through props

[yogeshbhutkar]

What?

Closes #69294

This PR would allow the consumers to set up the modal size within DataView actions.

Why?

The consumer implementation supports various modal behaviors but does not specify the size prop, which the internal Modal component supports. Currently, the size prop is hardcoded.

How?

The type declarations for ActionModal have been updated, allowing action.modalSize to be used as the prop for customization.

Testing Instructions

1. Start the storybook development server (npm run storybook:dev).
2. Add/modify the modalSize prop here in the action with id delete:

   gutenberg/packages/dataviews/src/components/dataviews/stories/fixtures.tsx

   Line 578 in 8898589

   export const actions: Action< SpaceObject >[] = [

3. Confirm that the modal size changes.

Screencast

dataviews.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @VanshDagar27.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: VanshDagar27.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[Mayank-Tripathi32]

Looks good to me

[yogeshbhutkar]

The failing test case is unrelated to the changes made in this PR and passes locally.

[yogeshbhutkar]

Hi @ciampo, I've updated this PR based on your feedback here. When you have a moment, could you please review the latest changes?

[ciampo]

This seems to work well in principle. It would be great to also get a 👍 from @ntsekouras, @jorgefilipecosta and/or @oandregal (although we don't have much time to work on Gutenberg, these days).

Also cc @t-hamano and @Mamaduka for visibility.

[t-hamano]

LGTM 👍There are currently some e2e test failures on trunk, but we'll merge once those are resolved.

[Mamaduka]

Rebasing should resolve e2e testing failures.