Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Align Table Header #69277

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Feb 21, 2025

What, Why and How?

Closes #69274

This PR corrects the misalignment of the Title button (the first button in the data-views header) by removing the unintended negative margin.

Testing Instructions

  1. Run storybook locally. (npm run storybook:dev)
  2. Navigate to DataViews and verify the Title button is now aligned with the rest of the content.

Screenshots

Before After
before after

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review February 21, 2025 12:22
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano
Copy link
Contributor

Thanks for the PR! Since #68840 has already been submitted, let's close this PR.

cc @im3dabasia

@t-hamano t-hamano closed this Feb 21, 2025
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] DataViews /packages/dataviews labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] DataViews /packages/dataviews [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataViews table layout: table header is not aligned with table rows and top-level controls
2 participants