Notice: Fix text contrast for dark mode #69226
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
fix/notice-color-dark-mode
branch
from
40f4da6 to
cc8f523
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Additional Context: I first noticed this problem when I suggested using the Notice component in the Site Editor (#69174 (comment)). If the Notice component did not have a black text color, the text would be very hard to see:
|
|
I wonder why they do not use the same style as the WordPress admin notices. Those do not have a background color change, only border color change? |
carolinan
approved these changes
Feb 18, 2025
ciampo
reviewed
Feb 18, 2025
| @@ -6,6 +6,7 @@ | |||
| border-left: 4px solid $components-color-accent; | |||
| padding: 8px 12px; | |||
| align-items: center; | |||
| color: $gray-900; | |||
There was a problem hiding this comment.
We have two choices:
- keep
Noticewith hardcoded colors, regardless of light / dark mode. This is what we're doing now, and the changes proposed in this PR are definitely an improvement over what's ontrunk; - make
Noticefollow the theme (including dark/light modes) and swap hardcodedbackground-colorandcolorvalues for the dynamic ones — although that may require design feedback and potential updates to the Design System, as also @carolinan suggested.
|
Thank you everyone for your feedback.
I don't know why, but the I think there will need to be a few more discussions about whether to only change the border and not the background color, or whether to dynamically change the background/text color. Therefore, for now, I would like to ship this PR. |
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
Co-authored-by: t-hamano <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #66454 (comment)
Why?
The text in the
Noticecomponent has no explicit text color applied to it, so it will appear white in dark mode. As a result, the text will be invisible in most statuses.How?
Apply an explicit black text color. This value also matches the text color of the Placeholder component.
Testing Instructions
Launch Storybook and switch to dark mode.
Screenshots or screencast