-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Submenu: Add Layout Support #69225
base: trunk
Are you sure you want to change the base?
Navigation Submenu: Add Layout Support #69225
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I have tested the PR with the navigation block only, not the page list. Here are some notes and questions that I have from testing the PR: |
Hi @carolinan Thanks for sharing the feedback and apologies for the PR if it's not appropriate enough, The PR comes from the comment shared here: #43248 (comment)
Thanks for this, to me based on the above points it looks like that we should not include the layout option for this menu |
We can keep it open for a bit since others may have something to add. |
What?
Part of #43248
Why?
The block was missing the layout support
How?
The PR adds the following to the
block.json
of the block to support the 'Layout'Testing Instructions
Screenshots or screencast
Screen.Recording.2025-02-18.at.8.53.18.AM.mov