Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Restore Non-Themed Text Colors for optimizeReadabilityFor #68472

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

im3dabasia
Copy link
Contributor

Follow up: #68349
Related comment: #68349 (comment)

What?

Reverted to using non-theme-based CSS values when the optimizeReadabilityFor prop is used, aligning with its intended functionality.

Why?

The optimizeReadabilityFor prop takes a static background color as input. To ensure consistent readability, the corresponding text colors must remain as non-themed values.

How?

Reverted the specific changes to optimizeReadabilityFor introduced in PR #68349

@im3dabasia im3dabasia requested a review from ajitbohra as a code owner January 3, 2025 04:52
Copy link

github-actions bot commented Jan 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jan 3, 2025
@im3dabasia
Copy link
Contributor Author

Hi @mirka,
When you have a moment, could you please review my PR? It addresses this: #68349 (comment).

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick revert! Could you also add a changelog, and revert the unit test changes as well so they pass again?

@im3dabasia im3dabasia requested a review from mirka January 6, 2025 11:41
@im3dabasia
Copy link
Contributor Author

Thank you for the review, @mirka. 🙇

I’ve updated the CHANGELOG with the following text. Please let me know if you have any feedback or suggestions for improvement:

  • Heading: Revert text contrast fix for dark mode with optimizeReadabilityFor (#68472).
  • Text: Revert text contrast fix for dark mode with optimizeReadabilityFor (#68472).

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mirka mirka merged commit b80c80c into WordPress:trunk Jan 6, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 6, 2025
Gulamdastgir-Momin pushed a commit to Gulamdastgir-Momin/gutenberg that referenced this pull request Jan 23, 2025
…r` (WordPress#68472)

* fix: Reverted to use non theme based CSS values

* revert: Dark contrast tests for optimizeReadabilityFor, and updated CHANGELOG

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: mirka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants