-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Title: Transform added for paragraph and heading #68239
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi Team, Whenever you have some time, could you please review this PR? I’d really appreciate your feedback. Thanks in advance! |
Thank you for the ping. I actually looked at this earlier today but wanted to think about it for a bit before I responded. First, my major concern is that it has not been discussed what exactly should happen for example when a paragraph is transformed into a title block. I do feel that there needs to be a decision first. Is there a reason why the edit.js file is updated instead of using a transforms.js file? I believe using the separate file is preferred. As you found out, the block library should not depend on |
Thanks for pointing that out @carolinan I will add the transform code to a separate file, that will be the best way! |
I agree. The issue was originally proposed to be transformed to Heading/Paragraph, with no mention of the reverse. Changing from Headings/Paragraph should be discussed separately. |
What?
Fixes #52203
Why?
Currently Title block has no transform option for paragraph and heading.
How?
Added paragraph and heading transform to title block.
Testing Instructions
Screenshots or screencast
Screenshare.-.2024-12-23.1_54_34.PM.mp4