Backport: Block editor - Fix use focus return iframe. #68200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Dec 24, 2024
…ocus (#68060) Co-authored-by: Alex Lende <[email protected]>
t-hamano
force-pushed
the
fix/use-focus-return-iframe
branch
from
181118b to
9e75db5
Compare
t-hamano
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
I have rebased this PR using the wp/6.7 branch and tested it again. I think this PR is worth backporting to WP 6.7.2 and does not appear to have any other impact. Additional review would be appreciated.
Testing Instructions
1. Widget Editor
A problem was reported on #67809. This issue is fixed by this PR.
- Activate Twenty Twenty-One theme.
- Open the widget editor.
- Add a Group block.
- Click the Browse all button.
wp/6.7branch: ❌ The main inserter opens for a moment, but then closes immediately.- This PR: ✅ The main inserter opens.
wp/6.7 branch
885ce7ea0ef3b67a4b79433eaad9e86a.mp4
This PR
864ebc90624294b76b7ca230bf332211.mp4
2. Iframed block editor
This test procedure is from #67809, however the results are the same on the wp/6.7 branch and I am unable to reproduce what the original issue was.
- On the iframed block editor
- Add a group block
- Click the appender
- Press Escape
- Focus should be on the appender again
- Press Enter to open the inserter again
- Repeat test with the social icon block appended
wp/6.7 branch
d1eddcae8ed4667ddd73036dd8e367a2.mp4
|
The E2E test failures should be fixed once #68886 is merged. |
aaronjorbin
approved these changes
Jan 28, 2025
|
As far as I've tested, there have been no side effects from this PR, so I would like to merge it. If any issues arise, I will address them. |
This was referenced Jan 29, 2025
aaronjorbin
added a commit
to aaronjorbin/wordpress-develop
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: DAreRodz <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Lena Morita <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: PARTHVATALIYA <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: Tropicalista <[email protected]> Co-authored-by: aaronjorbin <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: danielpost <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: mt8 <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: sathyapulse <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: youknowriad <[email protected]>
aaronjorbin
added a commit
to aaronjorbin/wordpress-develop
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: DAreRodz <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Lena Morita <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: PARTHVATALIYA <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: Tropicalista <[email protected]> Co-authored-by: aaronjorbin <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: danielpost <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: mt8 <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: sathyapulse <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: youknowriad <[email protected]>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Reviewed-by audrasjb. Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad. Fixes #62889. git-svn-id: https://develop.svn.wordpress.org/branches/6.7@59762 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Reviewed-by audrasjb. Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad. Fixes #62889. Built from https://develop.svn.wordpress.org/branches/6.7@59762 git-svn-id: http://core.svn.wordpress.org/branches/6.7@59104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Backports #68060 to
wp/6.7branch to be in 6.7.2