-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AspectRatioDropdown: List theme aspect ratios as decimal values #67302
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @stian-overasen! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Any update on this issue @ellatrix @carolinan? Seems like low-hanging fruit. |
What?
This PR fixes the bug with custom theme aspect ratios (Issue #66077) in the image cropper tool by mapping the theme ratios as decimal values in the
AspectRatioDropdown
component (Same as is already done for the default aspect ratios)Why?
Solved issue #66077.
How?
Map theme aspect ratios as calculated decimal values (16:9 = 1.777) the same was that is already done for default aspect ratios.
Testing Instructions
theme.json
. Example below.Example of custom theme aspect ratio in theme.json:
Screencast before fix:
before.mp4
Screencast after fix:
after.mp4