Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command: Manage categories while Editing a category template #67029

Open
wants to merge 29 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

What?

Enhancement for the Editing a category template mentioned in #50407

Why?

Currently there is no command to manage categories while editing category templates.

How?

This PR adds adds "Manage Categories" command by default when the command palette is opened while editing category templates.

Testing Instructions

  • Log in to your WordPress dashboard.
  • Navigate to the Site Editor.
  • Click on Templates from the left panel.
  • The main section will display a list of all available templates.
  • Select the "All Archives" template, or any Category or Tag template you wish to edit.
  • The editor panel for the selected template will open.
  • Open the Command Palette by either pressing Cmd + K (on macOS) or using the command palette icon at the top.
  • The "Manage Categories" or "Manage Tags" command will appear by default.
  • This command will not appear for any other templates other than category or tag templates.
  • Click on the displayed command to be redirected to the respective management page (Categories or Tags) in the WordPress dashboard.

Screenshots or screencast

REC-20241115165442.mp4

Copy link

github-actions bot commented Nov 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Package] Editor /packages/editor labels Jan 14, 2025
const commands = [];

// Check if we are in the Site Editor and editing a category-related template
const isSiteEditor = window.location.href.includes( 'site-editor.php' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthick-murugan I don't believe this is the correct way to determine if we are in the Site Editor.
When I search the code base, the common method I see is:

const isSiteEditor = getPath( window.location.href )?.includes(
	'site-editor.php'
);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolinan - Updated the common method as per your advice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants