Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Color changes to be in sync with rest of the block for latest comment #66561

Conversation

Anuj-Rathore24
Copy link

What?

This PR solves the following issues #66536, which address that latest comment text color doesn't change color in sync with the whole block

Why?

Refreshing the page after adding latest comments and changing its color doesn't change text color again, Then only first line text color will change, Remaining text color will not change.

How?

By setting the key prop and handling null values, we ensure the block behaves as expected.

Testing Instructions

  • Select Latest comments block
  • Change its background color & text color from block settings.
  • Save the changes and publish the page.
  • View the editor side & front-end side.
  • Refresh the page.
  • Now, change block text color & background color again.

Screenshots or screencast

Screen.Recording.2024-10-29.at.7.16.29.PM.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Anuj-Rathore24 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Anuj-Rathore24! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 29, 2024
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Latest Comments Affects the Latest Comments Block labels Feb 17, 2025
@t-hamano
Copy link
Contributor

Thanks for the PR!

We need to fix the root cause of this problem, not the symptoms.
Probably we need to fix the ServerSideRender component itself. See #69220 for more details.

Let's close this PR and investigate the root cause.

@t-hamano t-hamano closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Comments Affects the Latest Comments Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants